Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression of omitting the 'plan name' mandatory field from the wizard #1418

Merged

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Dec 19, 2024

Reference: https://issues.redhat.com/browse/MTV-1845

Add back the 'plan name' mandatory field to be visible within the plan creation's wizard step 2, since otherwise creating the plan is blocked by the plan creation use cases.

Note: if we want to move the 'plan name' field to the wizard's step 1 page so that it will be next to the 'project name' new field, we need to think of a design that will answer the 2 use cases and that the plan name will be enforced as mandatory for those 2 use cases. See #1409

Reference: https://issues.redhat.com/browse/MTV-1845

Add back the 'plan name' mandatory field to be visible and set in the plan
creation's wizard step 2, since otherwise creating the plan is blocked
by the plan creation use cases.

Signed-off-by: Sharon Gratch <[email protected]>
Copy link

@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Dec 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.21%. Comparing base (13484d0) to head (f5cc768).
Report is 164 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   36.81%   36.21%   -0.60%     
==========================================
  Files         158      159       +1     
  Lines        2548     2579      +31     
  Branches      599      603       +4     
==========================================
- Hits          938      934       -4     
- Misses       1428     1463      +35     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgratch sgratch merged commit 386e5cf into kubev2v:main Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants